Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Oct 10, 2024

Description

While the state and UI existed already, this PR completes it with:

  • Cancel sharding action (requires confirmation)
  • Polling for shardKey or shardingError
    • polling starts when sharding state has been detected right away or reached after a successful sharding request
    • polling ends when either shardKey or shardingError is retrieved, or when the user cancels the sharding request
      -polling is paused when the plugin title is not displayed (this means the user is not in the workspace), and renewed if they come back. note: this is tied to the plugin title and not content because the title includes the unsharded warning
  • Simplified integration tests (index.spec.ts - testing redux + service in different scenarios).
Screenshot 2024-10-09 at 15 37 53 Screenshot 2024-10-10 at 14 31 24

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@paula-stacho paula-stacho changed the title Compass 8277 3 feat(global-writes): sharding in progress state COMPASS-8277 Oct 10, 2024
@github-actions github-actions bot added the feat label Oct 10, 2024
@paula-stacho paula-stacho added the no release notes Fix or feature not for release notes label Oct 10, 2024
@paula-stacho paula-stacho marked this pull request as ready for review October 10, 2024 12:32
@paula-stacho paula-stacho added wip and removed wip labels Oct 10, 2024
@paula-stacho paula-stacho changed the title feat(global-writes): sharding in progress state COMPASS-8277 feat(compass-global-writes): sharding in progress state COMPASS-8277 Oct 14, 2024
@paula-stacho paula-stacho merged commit eab7899 into main Oct 15, 2024
5 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8277-3 branch October 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants